EDM-3284: "root" stays the default user for applications#469
Merged
celdrake merged 1 commit intoflightctl:mainfrom Feb 4, 2026
Merged
EDM-3284: "root" stays the default user for applications#469celdrake merged 1 commit intoflightctl:mainfrom
celdrake merged 1 commit intoflightctl:mainfrom
Conversation
WalkthroughReplace the single Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
4429f1d to
cf5d967
Compare
cf5d967 to
83862dc
Compare
rawagner
approved these changes
Feb 4, 2026
83862dc to
d2071c1
Compare
celdrake
added a commit
to celdrake/flightctl-ui
that referenced
this pull request
Feb 4, 2026
(cherry picked from commit 76036a6)
celdrake
added a commit
that referenced
this pull request
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After some discussions, the Backend won't make
flightctlthe default user for therunAsfield.So we must treat unset "runAs" values as "root", though we want to promote the user choosing "flightctl" by default when creating new applicatoins, and having the UI explicitly setting the value even when it's the default (root).
Summary by CodeRabbit