Skip to content
This repository was archived by the owner on May 21, 2021. It is now read-only.

Issue #34 - Split off shared code into separate bundle#35

Open
ThomasGreiner wants to merge 1 commit intoflattr:masterfrom
ThomasGreiner:issue_34
Open

Issue #34 - Split off shared code into separate bundle#35
ThomasGreiner wants to merge 1 commit intoflattr:masterfrom
ThomasGreiner:issue_34

Conversation

@ThomasGreiner
Copy link
Collaborator

@ThomasGreiner ThomasGreiner commented Mar 16, 2018

This PR contains the following changes:

  • Introduced lib/common.js bundle
    • Use "factor-vinylify" package to create the bundles including the necessary directories
    • Extended bundle() function so that it bundles all files at once instead of each file individually
    • Added references to lib/common.js to each page that references a bundle
  • Renamed variable names in bundle() function to differentiate input/output file names
  • Updated tests

@ThomasGreiner ThomasGreiner self-assigned this Mar 16, 2018
@ThomasGreiner ThomasGreiner requested a review from erikvold March 21, 2018 17:26
Copy link
Collaborator

@erikvold erikvold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, sorry I missed this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments