feat(traffic): Add unknown domains sub-tab #36
Conversation
Code Review SummaryThis pull request introduces a valuable new "Unknown Domains" tab to the Traffic Dashboard. This feature provides dedicated insights into traffic originating from unconfigured domains, including top unknown domains and their source IPs. The implementation is well-structured, leveraging existing patterns and introducing new API calls and UI components effectively. 🚀 Key Improvements
💡 Minor Suggestions
|
nfebe
force-pushed
the
feat/configurable-detection-thresholds
branch
from
d45efea to
8cd7b90
Compare
Deploying flatrun-ui with
|
| Latest commit: |
22ed6d7
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://52c8c464.flatrun-ui.pages.dev |
| Branch Preview URL: | https://feat-configurable-detection.flatrun-ui.pages.dev |
![sourceant[bot]](https://avatars.githubusercontent.com/in/1161781?s=60&v=4){kind=small}
| <div class="suspicious-info"> | ||
| <code>{{ entry.ip }}</code> | ||
| <div class="unknown-domains-list"> | ||
| <span v-for="domain in entry.domains.slice(0, 3)" :key="domain" class="tag"> |
There was a problem hiding this comment.
The hardcoded number 3 for entry.domains.slice(0, 3) would be more maintainable if defined as a constant within the THRESHOLDS object. This makes it easier to adjust display limits consistently across similar UI elements without searching through the code.
| <span v-for="domain in entry.domains.slice(0, 3)" :key="domain" class="tag"> | |
| <span v-for="domain in entry.domains.slice(0, THRESHOLDS.MAX_UNKNOWN_DOMAIN_IPS_DISPLAY)" :key="domain" class="tag"> |
| <span v-for="domain in entry.domains.slice(0, 3)" :key="domain" class="tag"> | ||
| {{ domain }} | ||
| </span> | ||
| <span v-if="entry.domains.length > 3" class="tag">+{{ entry.domains.length - 3 }}</span> |
There was a problem hiding this comment.
Similar to the previous suggestion, referencing a constant from THRESHOLDS for entry.domains.length - 3 would improve maintainability and consistency.
| <span v-if="entry.domains.length > 3" class="tag">+{{ entry.domains.length - 3 }}</span> | |
| <span v-if="entry.domains.length > THRESHOLDS.MAX_UNKNOWN_DOMAIN_IPS_DISPLAY" class="tag">+{{ entry.domains.length - THRESHOLDS.MAX_UNKNOWN_DOMAIN_IPS_DISPLAY }}</span> |
| } finally { | ||
| loadingUnknown.value = false; | ||
| } |
There was a problem hiding this comment.
To maintain a consistent error reporting mechanism across the application, it's recommended to use the notifications store for displaying errors encountered during API calls. This provides a unified user experience for error feedback.
| } finally { | |
| loadingUnknown.value = false; | |
| } | |
| notifications.error("Error", `Failed to fetch unknown domain stats: ${e.message}`); |
Add sub-tab under Traffic & Performance to display requests to domains not matching any deployment, with top domains, source IPs, and ability to block suspicious actors. Signed-off-by: nfebe <fenn25.fn@gmail.com>
nfebe
force-pushed
the
feat/configurable-detection-thresholds
branch
from
8cd7b90 to
22ed6d7
Compare
Add sub-tab under Traffic & Performance to display requests to domains not matching any deployment, with top domains, source IPs, and ability to block suspicious actors.