-
Notifications
You must be signed in to change notification settings - Fork 0
feat(security): Add whitelisting and better security filtering #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Whitelist table with default internal IPs/paths prevents self-blocking - CRUD API for whitelist management (/api/security/whitelist) - RejectUnknownDomains config drops connections to unconfigured hosts - Real client IP extracted from CF-Connecting-IP/X-Forwarded-For headers - Docker gateway auto-whitelisted on startup - /stats endpoint includes networks and ports counts Signed-off-by: nfebe <fenn25.fn@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review complete. No specific code suggestions were generated. See the overview comment for a summary.
d3d6f04 to
5b413c3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review complete. No specific code suggestions were generated. See the overview comment for a summary.
Add API endpoint to track requests to domains not matching any configured deployment, useful for detecting reconnaissance attempts and misconfigured DNS. Signed-off-by: nfebe <fenn25.fn@gmail.com>
Code Review Summary✨ This pull request significantly enhances the agent's security capabilities by introducing an IP/CIDR/path whitelisting mechanism, both managed by the agent and integrated into Nginx via Lua scripts. It also adds functionality for tracking unknown domain traffic statistics and improves Nginx configuration flexibility. The changes introduce several valuable security and monitoring features. 🚀 Key Improvements
💡 Minor Suggestions
🚨 Critical Issues
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review complete. See the overview comment for a summary.
- Extend is_ip_in_cidr to handle both IPv4 and IPv6 addresses - Replace certificate-based reject with ssl_reject_handshake directive - Remove ensureDefaultSSLCert function and related crypto imports Signed-off-by: nfebe <fenn25.fn@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review complete. See the overview comment for a summary.
…tion