fix(security): Use curl with proper timeouts in health check

[nfebe]

BusyBox wget ignores --timeout flag causing security health endpoint to hang indefinitely. Switch to curl first with reliable timeouts.

[sourceant]

Code Review Summary

This review covers changes to the checkNginxCanReachAgent function in internal/infra/manager.go. The primary goal of the modification was to enhance the robustness of network reachability checks by reordering the network utility attempts (prioritizing curl) and adding a max-time option to the curl command. However, the change also inadvertently removed crucial documentation.

🚀 Key Improvements

• The curl command now includes a --max-time option, which provides a more comprehensive timeout mechanism, preventing the command from hanging indefinitely on slow responses.
• The reordering to prioritize curl is a sensible change, as curl is generally a more feature-rich and widely available utility in modern container images compared to wget.

💡 Minor Suggestions

• While effective, the multi-line fmt.Sprintf for constructing shell commands can be verbose. For more complex scenarios, consider encapsulating shell command execution logic into a reusable helper to improve readability and consistency, though this is a minor point for the current implementation.

🚨 Critical Issues

• The doc comment for the checkNginxCanReachAgent function, along with explanatory inline comments, was removed. This significantly degrades the code's readability and maintainability and must be restored to ensure clarity for future development.

[sourceant]

Review complete. No specific code suggestions were generated. See the overview comment for a summary.