Skip to content

Comments

fix for the pip-installed standardiser exe#12

Open
UnixJunkie wants to merge 1 commit intoflatkinson:masterfrom
UnixJunkie:patch-3
Open

fix for the pip-installed standardiser exe#12
UnixJunkie wants to merge 1 commit intoflatkinson:masterfrom
UnixJunkie:patch-3

Conversation

@UnixJunkie
Copy link
Contributor

I patched the pip-installed script in this way.
I don't know how to check if this is the proper fix for the pip package.
I just guess this is the way to fix it.

I patched the pip-installed script in this way.
I don't know how to check if this is the proper fix for the pip package.
@UnixJunkie
Copy link
Contributor Author

If this is integrated and the pip package is updated, please let me know
so that I can test.
It is very nice for end users if they can install the software via pip.
Thanks a lot,
Francois.

@UnixJunkie
Copy link
Contributor Author

Hello,
Did you have a chance to test this correction?
Thanks a lot,
Francois.

@flatkinson
Copy link
Owner

flatkinson commented Feb 11, 2019 via email

@UnixJunkie
Copy link
Contributor Author

Maybe @mnowotka can confirm this is a proper fix.

@UnixJunkie
Copy link
Contributor Author

not merged yet?!
I have to fix the install for all my colleagues who want to use this tool...

@simonbray
Copy link

simonbray commented Aug 17, 2020

Hi, can this be merged please? The pip install is broken without it:

(standardiser) simon@simon-notebook:~$ standardiser -h
Traceback (most recent call last):
  File "/home/simon/miniconda3/envs/standardiser/bin/standardiser", line 5, in <module>
    from standardiser.bin.standardiser import main
ImportError: No module named standardiser

entry_points={
'console_scripts': [
'standardiser=standardiser.bin.standardiser:main']},
'standardiser=standardiser.bin.standardise_mols:main']},

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'standardiser=standardiser.bin.standardise_mols:main']},
'standardise-mols=standardiser.bin.standardise_mols:main']},

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if the intent was renaming the command

@UnixJunkie
Copy link
Contributor Author

@simonbray you can do:

pip3 install chemo-standardizer

This is a fixed version of the same package.
I did this because the maintainers of standardiser were not responsive enough.

@simonbray
Copy link

@UnixJunkie thanks for the tip!

I help maintain a conda package for standardiser on conda-forge; this also offers a functional installation of version 0.1.9: conda install standardiser -c conda-forge.

Still it would be nice if this were fixed upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants