Flatpak aware libappindicator

[bbhtt]

No description provided.

[flathubbot]

🚧 Test build enqueued.

[flathubbot]

🚧 Started test build.

[flathubbot]

🚧 Test build succeeded. To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/185841/com.dropbox.Client.flatpakref

[flathubbot]

🚧 Test build enqueued.

[flathubbot]

🚧 Started test build.

[flathubbot]

🚧 Test build enqueued.

[flathubbot]

🚧 Test build was cancelled.

[flathubbot]

🚧 Started test build.

[flathubbot]

🚧 Test build succeeded. To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/185844/com.dropbox.Client.flatpakref

[flathubbot]

🚧 Test build enqueued.

[flathubbot]

🚧 Started test build.

[flathubbot]

🚧 Test build succeeded. To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/185850/com.dropbox.Client.flatpakref

[flathubbot]

🚧 Test build enqueued.

[flathubbot]

🚧 Started test build.

[flathubbot]

🚧 Test build succeeded. To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/185851/com.dropbox.Client.flatpakref

[wjt]

At least for me this didn't work – the icon was still missing in most cases.

I would take a different approach of rewriting the icon theme path from an /app/... path to the real path of the installation, via .flatpak-info.

[bbhtt]

It's doing that exactly and seems to work for me.

[bbhtt]

Are you sure you are on my branch of shared-modules?

[flathubbot]

🚧 Test build enqueued.

[wjt]

I must have misread... I'll check.

[flathubbot]

🚧 Started test build.

[flathubbot]

🚧 Test build succeeded. To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/188541/com.dropbox.Client.flatpakref

[wjt]

For me, the new build above doesn't work. When the menu first loads it gets the (blue) Dropbox icon but as soon as I try to interact with the menu it returns to the ••• icon.

Looking with Bustle, when the icon changes, Dropbox emits: org.kde.StatusNotifierItem.NewIcon (which has no arguments). Then the shell plugin queries the ("org.kde.StatusNotifierItem", "IconName") and ("org.kde.StatusNotifierItem", "IconAccessibleDesc") properties, but nothing to do with the theme path. I wonder if it's a bug in the shell extension..

[wjt]

So GetAll on /org/ayatana/NotificationItem/dropbox_client_7 includes:

"IconThemePath": <"/sysroot/home/wjt/.local/share/flatpak/app/com.dropbox.Client/x86_64/test/0830fc6aa82491ba5f10e1fc2d7dd684a5d3063124a191d0d8645a8f717fe180/files/share/icons">

but GetAll on /org/ayatana/NotificationItem/dropbox_client_7/Menu with interface ("com.canonical.dbusmenu",) gets:

({"IconThemePath": <@as []>, "Status": <"normal">, "TextDirection": <"ltr">, "Version": <uint32 3>},)

So I wonder if this is resetting the extension's idea of the icon theme path.

[bbhtt]

I see, i will take a look. I couldn't get the menu to show up for me.

[bbhtt]

Yea I'm getting no menu, what does it need to show up?

Screencast.mp4

[wjt]

Weird. I have GNOME Shell 43 with whatever version of the indicator extension is in Debian Stable, and it Simply Works.

[flathubbot]

✅ Test build committed. To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/185844/com.dropbox.Client.flatpakref

[flathubbot]

✅ Test build committed. To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/185841/com.dropbox.Client.flatpakref

[flathubbot]

✅ Test build committed. To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/185851/com.dropbox.Client.flatpakref

[flathubbot]

✅ Test build committed. To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/185844/com.dropbox.Client.flatpakref

[RichardFevrier]

The latest artifacts seems unavailable, anyway to re-run the build? I would like to test if on my machine. Thank you

[wjt]

bot, build

…

Message ID: ***@***.***>

[flathubbot]

🚧 Test build enqueued.

[flathubbot]

🚧 Started test build.

[flathubbot]

✅ Test build succeeded. To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/198348/com.dropbox.Client.flatpakref

[RichardFevrier]

Here is my testing result:

The current stable version released on flathub doesnt show any icon.
The one build with this PR shows the dropbox icon only if the device is not linked to your account (logout status). As soon as you link your device the icon disappear.
Both scenarios, I am able to interact with the menu.

Don't hesitate if you need more infos.

Environment:
OS: NixOS
Desktop Environment: Niri
Status bar: Waybar