Skip to content

Conversation

@En-En-Code
Copy link

You probably shouldn't accept this mess LMAO.

It's going to be too hard to expand onto this in the future.

I'll clean it up a bit more later. The bit masks are probably not super necessary, but string comparison is significantly slower than integer comparison.

@En-En-Code En-En-Code marked this pull request as ready for review July 21, 2022 19:54
@En-En-Code
Copy link
Author

I cleaned up a lot of the logic for determining "combo" hands, so that "combo through handtrap" detection can be written with a lot fewer headaches.

Also, I fixed the last card in the deck never being drawn, along with switching to a more uniform randomization method.

Even with all that, I still got a speed boost, which I will mostly attribute to faster detection of the same copy of a card being selected multiple times.

It this point, it is probably fine to merge if you want the changes I've made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant