Enhance get_translations() to optionally return full contents#7
Open
StasNemy wants to merge 2 commits intoflagist0:masterfrom
Open
Enhance get_translations() to optionally return full contents#7StasNemy wants to merge 2 commits intoflagist0:masterfrom
StasNemy wants to merge 2 commits intoflagist0:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for the great work on this codebase!
I added a small enhancement to the
get_translationsmethod to optionally return the full JSON response from the API via thereturn_contentsparameter. This makes it easier to access additional metadata (like frequencies, tags, source info, etc.) when needed, while preserving the original behavior of yielding just theterms.Hope this is useful — let me know if you'd prefer it to return a tuple or handle this differently!