Skip to content
This repository was archived by the owner on Jan 20, 2026. It is now read-only.

bugfix/media-image-tests#104

Merged
fivetran-joemarkiewicz merged 6 commits intomainfrom
bugfix/media-image-tests
Jul 23, 2025
Merged

bugfix/media-image-tests#104
fivetran-joemarkiewicz merged 6 commits intomainfrom
bugfix/media-image-tests

Conversation

@fivetran-joemarkiewicz
Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz commented Jul 10, 2025 •
edited
Loading

PR Overview

Package version introduced in this PR: v0.18.2

This PR addresses the following Issue/Feature(s): Issue #102

Summary of changes:

Removes the not_null test for the image_id field in the media_image staging model.

Submission Checklist

  • Alignment meeting with the reviewer (if needed)
    • Timeline and validation requirements discussed
  • Provide validation details:
    • Validation Steps: Check for unintentional effects (e.g., add/run consistency & integrity tests)
      • Confirmed based on the ERD that there's no indication that the image_id needs to be populated. The media_id is the PK and the test should remain there. But not necessary for the image_id.
      • Additionally, when inspecting the API docs you can see the id field is not_null enforced, but image is able to be null if no image is available.
    • Testing Instructions: Confirm the change addresses the issue(s)
      • Confirm the BK tests pass.
    • Focus Areas: Complex logic or queries that need extra attention
      • No major focus areas to callout.

Changelog

  • Draft changelog for PR
  • Final changelog for release review

fivetran-data-model-bot and others added 2 commits July 23, 2025 13:03
@fivetran-data-model-bot @fivetran-catfritz @fivetran-joemarkiewicz
Q2 FY26 Automatic Package Updates (#105)
b685dae 
* Q2 FY26: Apply automated update.

* Q2 FY26: Update auto-release workflow only.

---------

Co-authored-by: fivetran-catfritz <111930712+fivetran-catfritz@users.noreply.github.com>
Co-authored-by: Joe Markiewicz <74217849+fivetran-joemarkiewicz@users.noreply.github.com>
@fivetran-joemarkiewicz
Update dbt_project.yml
fbc2766
@fivetran-joemarkiewicz fivetran-joemarkiewicz linked an issue Jul 23, 2025 that may be closed by this pull request
shopify__discounts table skipped casuses downstream models to be skipped #102
Closed
@fivetran-joemarkiewicz fivetran-joemarkiewicz marked this pull request as ready for review July 23, 2025 18:39
fivetran-avinash
fivetran-avinash reviewed Jul 23, 2025
View reviewed changes
fivetran-avinash
fivetran-avinash reviewed Jul 23, 2025
View reviewed changes
fivetran-avinash
fivetran-avinash reviewed Jul 23, 2025
View reviewed changes
fivetran-avinash
fivetran-avinash reviewed Jul 23, 2025
View reviewed changes
fivetran-avinash
fivetran-avinash approved these changes Jul 23, 2025
View reviewed changes
Copy link
Contributor

@fivetran-avinash fivetran-avinash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fivetran-joemarkiewicz few suggestions but nothing blocking, approved!

@fivetran-joemarkiewicz fivetran-joemarkiewicz added the docs:ready Triggers the docs generator workflow. label Jul 23, 2025
fivetran-catfritz
fivetran-catfritz approved these changes Jul 23, 2025
View reviewed changes
Copy link
Contributor

@fivetran-catfritz fivetran-catfritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a small suggestion.

@fivetran-joemarkiewicz @fivetran-catfritz
Update CHANGELOG.md
cc03ae0 
Co-authored-by: fivetran-catfritz <111930712+fivetran-catfritz@users.noreply.github.com>
@fivetran-joemarkiewicz fivetran-joemarkiewicz merged commit 0fb37da into main Jul 23, 2025
9 checks passed
@fivetran-joemarkiewicz fivetran-joemarkiewicz deleted the bugfix/media-image-tests branch July 23, 2025 20:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@fivetran-avinash fivetran-avinash fivetran-avinash approved these changes

@fivetran-catfritz fivetran-catfritz fivetran-catfritz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@fivetran-joemarkiewicz fivetran-joemarkiewicz

Labels

docs:ready Triggers the docs generator workflow.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

shopify__discounts table skipped casuses downstream models to be skipped

4 participants

@fivetran-joemarkiewicz @fivetran-avinash @fivetran-catfritz @fivetran-data-model-bot