Add HTTP Request Component #31
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ci skip] [skip ci]
Apply fixes from StyleCI
…component/http-request
Codecov Report
@@ Coverage Diff @@
## master #31 +/- ##
============================================
- Coverage 86.74% 80.17% -6.58%
- Complexity 335 420 +85
============================================
Files 18 22 +4
Lines 830 1024 +194
============================================
+ Hits 720 821 +101
- Misses 110 203 +93
Continue to review full report at Codecov.
|
marktopper
commented
Apr 28, 2017
src/Fist/Http/tests/RequestTest.php
Outdated
| use Fist\Http\Request; | ||
| use Fist\Testing\TestCase; | ||
|
|
||
| class RequestTest extends TestCase |
Member
Author
There was a problem hiding this comment.
[phpmd]
- The class RequestTest has 16 public methods. Consider refactoring RequestTest to keep number of public methods under 10.
marktopper
commented
Apr 28, 2017
src/Fist/Http/tests/RequestTest.php
Outdated
| use Fist\Testing\TestCase; | ||
| use Fist\Testing\WithSuperGlobals; | ||
|
|
||
| class RequestTest extends TestCase |
Member
Author
There was a problem hiding this comment.
[phpmd]
- The class RequestTest has 16 public methods. Consider refactoring RequestTest to keep number of public methods under 10.
[ci skip] [skip ci]
Apply fixes from StyleCI
…component/http-request
marktopper
commented
Apr 28, 2017
|
|
||
| namespace Fist\Http; | ||
|
|
||
| class Request |
Member
Author
There was a problem hiding this comment.
[phpmd]
- The class Request has an overall complexity of 50 which is very high. The configured complexity threshold is 50.
marktopper
commented
Apr 28, 2017
src/Fist/Http/tests/RequestTest.php
Outdated
| /** | ||
| * @SuppressWarnings(PHPMD.ExcessivePublicCount) | ||
| */ | ||
| class RequestTest extends TestCase |
Member
Author
There was a problem hiding this comment.
[phpmd]
- The class RequestTest has 16 public methods. Consider refactoring RequestTest to keep number of public methods under 10.
marktopper
commented
Apr 28, 2017
|
|
||
| protected $requestUri; | ||
|
|
||
| public function __construct(array $query = [], array $request = [], array $cookies = [], array $files = [], array $server = [], $content = null) |
Member
Author
There was a problem hiding this comment.
[code_sniffer]
- Line exceeds 120 characters; contains 148 characters
marktopper
commented
Apr 28, 2017
| return new static($_GET, $_POST, $_COOKIE, $_FILES, $_SERVER); | ||
| } | ||
|
|
||
| public function initialize(array $query = [], array $request = [], array $cookies = [], array $files = [], array $server = [], $content = null) |
Member
Author
There was a problem hiding this comment.
[code_sniffer]
- Line exceeds 120 characters; contains 147 characters
marktopper
commented
Jun 28, 2017
| $request = Request::createFromGlobals(); | ||
|
|
||
| $fingerprint = sha1(implode('|', array_merge( | ||
| $route->methods(), [$route->domain(), $route->uri(), $this->ip()] |
Member
Author
There was a problem hiding this comment.
[code_sniffer]
- Only one argument is allowed per line in a multi-line function call
Member
Author
|
Click here if you want to create code_sniffer's auto-correct Pull Request See the documentation if you want to get more information about auto-correct. |
marktopper
commented
Jun 28, 2017
|
|
||
| namespace Fist\Http; | ||
|
|
||
| class Request |
Member
Author
There was a problem hiding this comment.
[phpmd]
- The class Request has 11 public methods. Consider refactoring Request to keep number of public methods under 10.
- The class Request has an overall complexity of 51 which is very high. The configured complexity threshold is 50.
Member
Author
|
Auto-correctable file didn't exist on this Pull Request from SideCI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a HTTP Request Component