Skip to content

Conversation

@MiloszFilimowski
Copy link
Collaborator

Description

  • Mediastream usage was not reflected in docs and missing in RTCPIPView

@linear
Copy link

linear bot commented Jan 21, 2026

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the mobile client’s WebRTC view overrides to expose media-stream-based usage in both RTCView and RTCPIPView, and aligns the package index exports with these wrappers.

Changes:

  • Refactors RTCView override to accept a mediaStream prop, derive streamURL via a shared convertMediaStreamToURL helper, and base its props type on ComponentPropsWithRef<typeof OriginalRTCView> minus streamURL.
  • Introduces an analogous RTCPIPView wrapper that also derives streamURL from a mediaStream and re-exports its component and props from the package index.
  • Updates packages/mobile-client/src/index.ts to re-export the new RTCPIPView and its props, and to rely on the overridden versions instead of the originals for public API.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
packages/mobile-client/src/overrides/RTCView.tsx Adds a shared convertMediaStreamToURL helper, updates RTCView to use mediaStream, and introduces an RTCPIPView wrapper that mirrors this behavior.
packages/mobile-client/src/index.ts Re-exports the overridden RTCView/RTCPIPView components and their props, and stops re-exporting the original RTCPIPView directly.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@MiloszFilimowski MiloszFilimowski merged commit 38c9582 into main Jan 21, 2026
8 checks passed
@MiloszFilimowski MiloszFilimowski deleted the fce-2487-fix-media-stream branch January 21, 2026 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants