remove obsolete field from e2e tests #457
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the obsolete enableSimulcast parameter from the createPeer function in e2e test utilities. The parameter was previously used to control simulcast behavior when creating WebRTC peers but is no longer needed.
Changes:
- Removed
enableSimulcastparameter fromcreatePeerfunction signature - Removed
enableSimulcastfrom the request options object - Simplified options to an empty object
{}
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| e2e-tests/webrtc-client/scenarios/utils.ts | Removed obsolete enableSimulcast parameter from createPeer function and cleaned up options |
| e2e-tests/react-client/scenarios/utils.ts | Removed obsolete enableSimulcast parameter from createPeer function and cleaned up options |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
czerwiukk
approved these changes
Jan 21, 2026
Gawor270
deleted the
fix-e2e-tests-after-fishjam-body-request-fields-restriction
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fishjam API is no longer supporting enableSimulcast field when creating peer
Motivation and Context
Why is this change required? What problem does it solve? If it fixes an open
issue, please link to the issue here.
Documentation impact
Types of changes
not work as expected)