Skip to content

Conversation

@anna1901
Copy link
Contributor

Description

Remove toggleMicrophoneMute from mobile as it's not needed.

Documentation impact

  • Documentation update required
  • Documentation updated in another PR
  • No documentation update required

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)

@linear
Copy link

linear bot commented Jan 21, 2026

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the toggleMicrophoneMute method from the mobile client's useMicrophone hook by using TypeScript's Omit utility type to exclude it from the return type. This change aligns with the pattern used elsewhere in the codebase where certain features are not supported on mobile platforms.

Changes:

  • Import useMicrophone from @fishjam-cloud/react-client with an alias
  • Remove useMicrophone from the direct re-export list
  • Create a custom export that omits the toggleMicrophoneMute method from the return type

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@MiloszFilimowski MiloszFilimowski merged commit 9be3b63 into main Jan 21, 2026
2 checks passed
@MiloszFilimowski MiloszFilimowski deleted the FCE-2631/remove-toggleMicrophoneMute branch January 21, 2026 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants