Skip to content

Conversation

@czerwiukk
Copy link
Member

Adds Fishjam ID as a part of the Connect API changes.
@AHGIJMKLKKZNPJKQR and @roznawsk feel free to suggest a better API

@czerwiukk czerwiukk self-assigned this Jul 28, 2025
@linear
Copy link

linear bot commented Jul 28, 2025

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces support for using a fishjam_id parameter as an alternative to providing a full fishjam_url when initializing Fishjam clients. The implementation allows clients to be created with either a complete URL or just an ID, which gets converted to a standardized URL format.

  • Adds a new utility function to handle URL generation from either fishjam_id or fishjam_url
  • Updates client constructors to accept fishjam_id as a primary parameter with fishjam_url as an optional fallback
  • Modifies example code to use the new fishjam_id parameter instead of fishjam_url

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
fishjam/utils.py New utility function to generate fishjam URL from ID or use provided URL
fishjam/errors.py Custom exception for missing fishjam ID/URL validation
fishjam/api/_fishjam_client.py Updated constructor to accept fishjam_id as primary parameter
fishjam/api/_client.py Modified base client to use new URL generation logic
fishjam/_ws_notifier.py Updated WebSocket notifier to support fishjam_id parameter
examples/room_manager/room_service.py Example updated to use fishjam_id and removed unused url field
examples/room_manager/arguments.py Command line arguments updated to support fishjam_id
.tool-versions Added Python and Poetry version specifications
Comments suppressed due to low confidence (1)

.tool-versions:2

  • Poetry version 2.1.3 does not exist. The latest Poetry version as of early 2025 is 1.x series. Consider using a valid Poetry version like 1.8.3.
poetry 2.1.3

@czerwiukk czerwiukk marked this pull request as draft July 28, 2025 13:17
@czerwiukk czerwiukk marked this pull request as ready for review July 28, 2025 14:35
@czerwiukk czerwiukk requested a review from PiotrWodecki July 29, 2025 08:16
@czerwiukk czerwiukk merged commit 96359be into main Jul 29, 2025
4 checks passed
@czerwiukk czerwiukk deleted the FCE-1780/accept-fishjam-id branch July 29, 2025 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants