-
Notifications
You must be signed in to change notification settings - Fork 1
Migration guide #218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Migration guide #218
Conversation
bd0f47d to
380c9c7
Compare
16172db to
5ae2e0a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR introduces a comprehensive migration guide to help developers transition from the legacy @fishjam-cloud/react-native-client to the new @fishjam-cloud/mobile-client package.
Changes:
- Documents package installation and import changes
- Explains the new FishjamProvider context requirement and device initialization patterns
- Details API changes for video rendering, connection management, device controls, screen sharing, and Picture-in-Picture functionality
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <Button title="Start PiP" onPress={() => startPIP(pipViewRef as any)} /> | ||
| <Button title="Stop PiP" onPress={() => stopPIP(pipViewRef as any)} /> |
Copilot
AI
Jan 23, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using 'as any' type assertions defeats TypeScript's type safety. The ref type should be properly defined to match the expected type for startPIP and stopPIP functions, or these functions should accept the current ref type.
| <Button title="Start PiP" onPress={() => startPIP(pipViewRef as any)} /> | |
| <Button title="Stop PiP" onPress={() => stopPIP(pipViewRef as any)} /> | |
| <Button title="Start PiP" onPress={() => startPIP(pipViewRef)} /> | |
| <Button title="Stop PiP" onPress={() => stopPIP(pipViewRef)} /> |
| ); | ||
| } | ||
|
|
||
| const YourApp = () => {return (<><Text>Your app content</Text></>);}; |
Copilot
AI
Jan 23, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This example component is unnecessarily condensed onto a single line, making it harder to read. Consider formatting it with proper line breaks for better readability in documentation.
| const YourApp = () => {return (<><Text>Your app content</Text></>);}; | |
| const YourApp = () => { | |
| return ( | |
| <> | |
| <Text>Your app content</Text> | |
| </> | |
| ); | |
| }; |
Description
Migration guide for the new mobile sdk