Skip to content

Conversation

@anna1901
Copy link
Contributor

Description

Migration guide for the new mobile sdk

@MiloszFilimowski MiloszFilimowski force-pushed the new-mobile-package branch 2 times, most recently from bd0f47d to 380c9c7 Compare January 21, 2026 11:20
Base automatically changed from new-mobile-package to main January 21, 2026 22:02
@anna1901 anna1901 requested a review from Copilot January 23, 2026 17:24
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces a comprehensive migration guide to help developers transition from the legacy @fishjam-cloud/react-native-client to the new @fishjam-cloud/mobile-client package.

Changes:

  • Documents package installation and import changes
  • Explains the new FishjamProvider context requirement and device initialization patterns
  • Details API changes for video rendering, connection management, device controls, screen sharing, and Picture-in-Picture functionality

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +404 to +405
<Button title="Start PiP" onPress={() => startPIP(pipViewRef as any)} />
<Button title="Stop PiP" onPress={() => stopPIP(pipViewRef as any)} />
Copy link

Copilot AI Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using 'as any' type assertions defeats TypeScript's type safety. The ref type should be properly defined to match the expected type for startPIP and stopPIP functions, or these functions should accept the current ref type.

Suggested change
<Button title="Start PiP" onPress={() => startPIP(pipViewRef as any)} />
<Button title="Stop PiP" onPress={() => stopPIP(pipViewRef as any)} />
<Button title="Start PiP" onPress={() => startPIP(pipViewRef)} />
<Button title="Stop PiP" onPress={() => stopPIP(pipViewRef)} />

Copilot uses AI. Check for mistakes.
);
}

const YourApp = () => {return (<><Text>Your app content</Text></>);};
Copy link

Copilot AI Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This example component is unnecessarily condensed onto a single line, making it harder to read. Consider formatting it with proper line breaks for better readability in documentation.

Suggested change
const YourApp = () => {return (<><Text>Your app content</Text></>);};
const YourApp = () => {
return (
<>
<Text>Your app content</Text>
</>
);
};

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants