Skip to content

Return dummy value in listBuildStatuses for Github, bc. merge check i… #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cptwunderlich wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Return dummy value in listBuildStatuses for Github, bc. merge check i… #253

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 6 additions & 11 deletions core/src/main/scala/com/fgrutsch/emergence/core/vcs/github/GithubVcs.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,17 +61,12 @@ final class GithubVcs[F[_]: Temporal](using backend: SttpBackend[F, Any], settin

override def listBuildStatuses(repo: Repository, pr: PullRequest): F[List[BuildStatus]] = {

val uri =
settings.apiHost.addPath("repos", repo.owner, repo.name, "commits", pr.sourceBranchHead.toString, "status")

basicRequest
.get(uri)
.header("X-GitHub-Api-Version", "2022-11-28")
.header("Accept", "application/vnd.github+json")
.withAuthentication()
.response(asJson[BuildStatus])
.send(backend)
.flatMap(r => TMP.fromEither(r.body.map(List(_))))
// This used to check the build status of the PR's head commit.
// However, this is not a reliable way to get the build status of a PR.
// Often, we'd only get a `PENDING` back, which also indicates no build status is available.
// We have to only rely on the merge check.
// See: https://docs.github.com/en/rest/guides/using-the-rest-api-to-interact-with-your-git-database?apiVersion=2022-11-28#checking-mergeability-of-pull-requests
TMP.pure(List(BuildStatus(BuildStatusName("success"), BuildStatusState.Success)))
}

override def mergePullRequest(
Expand Down