-
Notifications
You must be signed in to change notification settings - Fork 4
Add GitHub Action for running tests #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Running $ ff test
⏳ installing dependencies...
Collecting pytest
Using cached pytest-9.0.2-py3-none-any.whl.metadata (7.6 kB)
ERROR: Could not find a version that satisfies the requirement firefly-test (from versions: none)
[notice] A new release of pip is available: 25.1.1 -> 25.3
[notice] To update, run: /home/kalle/code/firefly-go/.venv/bin/python3 -m pip install --upgrade pip
ERROR: No matching distribution found for firefly-test
💥 Error: install firefly-test: subprocess exited with status code 1.I don't know crap about Python. This is very much outside my domain. I've no clue how to debug it |
Why? Github Actions CI by default doesn't have access to any secrets and we don't need any.
Yeah, I made builds for firefly-test only for Python 3.12 and Linux. I've gotta fix it with CI. |
Why? Let's keep it simple. It's invaluable to have CI and local env behave the same way. |
I don't want to keep monitoring and merging dependabot updates, i already have 250 foss projects. just let it run on latest everything and i'll fix it if it ever breaks. |
Valid. I just added it as a good default. And if you add Dependabot there's no maintenance burden either. Better to do it everywhere than to only do it in some places and then forget to change it to use commit hashes later once you start using secrets. Who's to say you won't add secrets later? If you insist then I'll revert to using the
I wrote a comment to motivate it firefly-go/.github/workflows/ci.yml Lines 43 to 44 in a0b34e5
I forgot to also mention the motivation in the PR description. But I'll revert it to just using the Taskfile for that too.
I use auto-merging GitHub actions for that on some of my repos :) |
Runs the linting and test steps in GitHub Actions.
Some notable changes:
task lint# v1.2.3comment and helps keep that up-to-date tooCloses #3