-
Notifications
You must be signed in to change notification settings - Fork 177
MixedInterpolator #4596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MixedInterpolator #4596
Conversation
71f6165 to
6061910
Compare
|
How will this extend when #3478 goes in and we can define MixedFunctionSpaces on multiple domains? |
0f44ddb to
f21dad9
Compare
I believe this approach should give us the matfree adjoint and the forward/adjoint matrices for that case, as long as each MFS component on the source and target are defined on standard, possibly distintict meshes/submeshes. |
8d631f8 to
3b92d36
Compare
6e5b5cb to
2db1ab1
Compare
2db1ab1 to
3bd935e
Compare
|
This needed more work after FEniCS/ufl#422 was merged. We now split the sub interpolators via the same mechanism that handles fieldsplit, so this should be much cleaner. |
connorjward
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I'm mostly happy now. Definitely good to see so much deleted code.
There could definitely be more docstrings and type hints but there are at least some.
Description
Enables assembly of the interpolation matrix for mixed spaces
We also allow the operand to be any expression, resulting in non-zero off diagonal blocks.
This is the last step required to clean up the special cases of an
Interpolateinassemble.py.