Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/code-check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,10 @@ jobs:
with:
ref: ${{ inputs.branch }}

- name: Set up Python 3.9
- name: Set up Python 3.12
uses: actions/setup-python@v5
with:
python-version: 3.9
python-version: 3.12

- name: Install dependencies
run: |
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/unit-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,10 @@ jobs:
with:
ref: ${{ inputs.branch }}

- name: Set up Python 3.9
- name: Set up Python 3.12
uses: actions/setup-python@v2
with:
python-version: 3.9
python-version: 3.12

- name: Install dependencies
run: |
Expand Down
21 changes: 9 additions & 12 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ repos:
args:
- --include-version-classifiers

- repo: https://github.com/myint/autoflake
rev: v1.4
- repo: https://github.com/PyCQA/autoflake
rev: v2.3.1
hooks:
- id: autoflake
args:
Expand All @@ -23,6 +23,7 @@ repos:
- --ignore-init-module-imports
- --remove-duplicate-keys
- --remove-unused-variables
language_version: '3.12'

- repo: https://github.com/PyCQA/isort
rev: "5.12.0"
Expand All @@ -33,23 +34,19 @@ repos:
rev: 22.3.0
hooks:
- id: black
language-version: 3.9

- repo: https://github.com/dfm/black_nbconvert
rev: v0.4.0
hooks:
- id: black_nbconvert
language_version: '3.12'
- id: black-jupyter
language_version: '3.12'

- repo: https://github.com/PyCQA/flake8
rev: "4.0.1"
rev: "7.1.1"
hooks:
- id: flake8
additional_dependencies:
- flake8-tidy-imports
- flake8-quotes
# - flake8-docstrings
# - flake8-spellcheck
# - darglint
language_version: '3.12'

- repo: local
hooks:
- id: mypy
Expand Down
1 change: 1 addition & 0 deletions src/firebolt/common/_types.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ def align_ms(match: re.Match) -> str:

return re.sub(unsupported_milliseconds_re, align_ms, datetime_string)

#just testing sonar
def _fix_timezone(datetime_string: str) -> str:
# timezone, provided as +/-dd is not supported by datetime.
# We need to append :00 to it
Expand Down
Loading