Skip to content

Conversation

@zlifb
Copy link

@zlifb zlifb commented Nov 24, 2023

PackDB PR: https://github.com/firebolt-analytics/packdb/pull/8531 .

We used to define the signature of substring function following PostgreSQL, which has <start> and <count> parameters defined as INTEGER. Calling substring with BIGINT values for these parameters fail in PostgreSQL, and we kept the same behavior.

However, we agreed that this is not very convenient. Supporting BIGINT types for these parameters should be a natural extension. It does not hurt our "PostgreSQL compliant" claim. In addition, given that we still produce BIGINT for arithmetic addition of integers, this is just convenient for our user to make in-position call to other functions.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@molly-firebolt
Copy link
Contributor

molly-firebolt commented Nov 27, 2023

Thank you for the PR @zlifb - is this behavior already live, or do we need to wait for a release version to be tagged on the ticket?

@zlifb
Copy link
Author

zlifb commented Nov 29, 2023

@molly-firebolt The change is merged in master, but not included in the 3.30 release. So it will be in for 3.31 I assume. I tried to tag the Jira ticket but there seems to be no packdb-3.31 yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants