Conversation
…ameter packs for a unified and sleek API' as complete
…ameter packs for a unified and sleek API' as complete
ctreffs
commented
Feb 13, 2026
1d2d4c5 to
284e992
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors Fireblade ECS to leverage Swift Parameter Packs (SE-0393), replacing the previous Sourcery-based code generation for
Familytypes. This modernization results in a significantly smaller codebase, easier maintenance, and a more idiomatic Swift API while maintaining strict feature parity and performance.Key Features & Improvements
Family1throughFamily8(and beyond) with a single, variadicFamily<each C: Component>.SequenceandIteratorProtocolsupport forFamily, enabling the familiarfor (pos, vel) in familysyntax without performance degradation.FamilyMemberContainerlogic has been preserved to maintain compatibility with existing serialized data.Nexus.family(requiresAll: ...)now accepts an arbitrary number of component types.Nexus.createEntity(with: ...)now supports parameter packs for type-safe entity creation.requires:overload for single-component families has been maintained for ease of use.Family,ComponentsIterator,EntityIterator, andEntityComponentIteratornow conform toSendable, improving thread safety guarantees..sourcery.yml, templates, andMintfileentries.Testing
FamilyTests1.swiftthroughFamilyTests8.swift) to verify API correctness across varying component counts (1 to 8+).Codableround-trip and feature parity withFamilyCodingTests.swift.Source Impact
Family1,Family2, etc. type aliases are removed in favor ofFamily<C1, C2, ...>.Checklist