Add pipeline snippets for web and nodejs #404
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markarndt
approved these changes
Nov 5, 2025
MarkDuckworth
left a comment
MarkDuckworth
left a comment
There was a problem hiding this comment.
I did not finish the review, but here is some high level feedback that needs to be addressed. Some across all samples.
morganchen12
commented
Nov 6, 2025
MarkDuckworth
approved these changes
Nov 6, 2025
MarkDuckworth
left a comment
MarkDuckworth
left a comment
There was a problem hiding this comment.
Approved with comments. There are a few remaining errors and a few nits I commented on.
| field("tags").arrayConcat([ | ||
| field("pages").greaterThan(100) | ||
| .conditional(constant("longRead"), constant("shortRead")) | ||
| ]).as("extendedTags") |
| } | ||
|
|
||
| async function strSplitFunction() { | ||
| // not yet supported until GA |
Contributor
Author
There was a problem hiding this comment.
I wasn't able to find this method after updating both the web and iOS SDKs. I haven't checked the other ones yet.
Add missing START/END for ends_with
* add admin snippets temporarily * write node snippets * run snippets
morganchen12
changed the title
morganchen12
force-pushed
the
mc/pipelines
branch
from
d5bdfca to
ca4024e
Compare
| // old snippets | ||
|
|
||
| async function basicRead() { | ||
| // [START basic_read] |
There was a problem hiding this comment.
Seems like we can just add
// The import/require of 'firebase/firestore/pipelines' has a side effect
// of extending the Firestore class with the `.pipeline()` method.
// Without this import/require, you will not be able to create a Pipeline
const { execute } = require("firebase/firestore/pipelines");
And that will generate the expected snippet with import in snippets/firestore-next/...
Contributor
Author
There was a problem hiding this comment.
Done, though I commented out the import to prevent a CI failure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.