Replace Extlib with Inflecto #51
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like Extlib is being included specifically for its string transformations API. Inflecto is a smaller Gem which provides the same functionality and means that the whole of Extlib doesn’t need to be loaded to get a small subset of features.
qnm
reviewed
Nov 17, 2016
| bootstrapper = Pathname.new(__FILE__).dirname.join('bootstrap.rb').expand_path | ||
|
|
||
| binary = Smith.config.vm[agent_process.name.snake_case.to_sym] || Smith.config.vm.agent_default | ||
| binary = Smith.config.vm[Inflecto.undercore(agent_process.name).to_sym] || Smith.config.vm.agent_default |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like Extlib is being included specifically for its string transformations API. Inflecto is a smaller Gem which provides the same functionality and means that the whole of Extlib doesn’t need to be loaded to get a small subset of features.
Another consequence is that there’s no monkeypatching of the core string class.
Warning: I need to test this more thoroughly to confirm that it works. Just want to get feedback on whether this is a good idea or not.