Skip to content

fix: invalid deployment instructions#10

Open
florrdv wants to merge 2 commits intofigma:mainfrom
florrdv:main
Open

fix: invalid deployment instructions#10
florrdv wants to merge 2 commits intofigma:mainfrom
florrdv:main

Conversation

@florrdv
Copy link

@florrdv florrdv commented Jul 21, 2024

The Vercel deployment instructions include a trailing slash, which causes the origin checks in onmessage (dd2b2c5) to fail due to props.origin not including this trailing slash. This causes the onmessage handler to return early and none of the code there to be executed.

This PR introduces a small change to the deployment instructions to account for origin checking & updates package.json to remove the trailing slash from siteURL.

@florrdv
Copy link
Author

florrdv commented Jul 21, 2024

Should resolve #9

@klyap
Copy link

klyap commented Jul 23, 2024

Tested and confirmed that this fix worked for me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants