Skip to content

fixing preemptive logging of task completion #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BeauchesneFieldDay merged 2 commits into from
Jan 22, 2026
Merged

fixing preemptive logging of task completion #40

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
791a0c2
fixing preemptive logging of task completion
XanGrab Jan 20, 2026
a06d7c5
* incremented client log version
BeauchesneFieldDay Jan 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions Assets/_Modules/Analytics/AnalyticsService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ namespace Aqua
public partial class AnalyticsService : ServiceBehaviour, IDebuggable
{
private const string NoActiveJobId = "no-active-job";
private const int ClientLogVersion = 5;
private const int ClientLogVersion = 6;

static private readonly string[] FactTypeStringTable = Enum.GetNames(typeof(BFTypeId));

Expand Down Expand Up @@ -339,7 +339,6 @@ private void UpdateJobInfo(StringHash32 id) {
var task = tasks[i];
ref var taskData = ref m_GameState.task_list[i];
taskData.task_id = task.IdString;
// taskData.task_description = Loc.Find(task.LabelId);
taskData.is_complete = Save.Jobs.IsTaskComplete(task.Id);
}
}
Expand Down Expand Up @@ -595,17 +594,15 @@ private void LogSelectLanguage(FourCC langCode) {
}
}

private void SetCurrentJob(StringHash32 jobId)
{
private void SetCurrentJob(StringHash32 jobId) {
m_CurrentJobHash = jobId;
m_PreviousJobName = m_GameState.job_id;

UpdateJobInfo(jobId);
RefreshGameState();
}

private void LogAcceptJob(StringHash32 jobId)
{
private void LogAcceptJob(StringHash32 jobId) {
RefreshGameState();
using(var e = m_Log.NewEvent("accept_job")) {
}
Expand Down Expand Up @@ -726,11 +723,11 @@ private void FinalFinalSurveyTriggerCheck(SceneBinding s, object c) {
private void LogCompleteTask(StringHash32 jobId, StringHash32 inTaskId){
string taskId = Assets.Job(jobId).Task(inTaskId).IdString;

UpdateJobTaskCompletion();
RefreshGameState();
using(var e = m_Log.NewEvent("complete_task")) {
e.Param("task_id", taskId);
}
UpdateJobTaskCompletion();
}

private void LogBeginDive(string inTargetScene)
Expand Down
Loading