Conversation
fgerling
left a comment
There was a problem hiding this comment.
I'm looking forward to a call. Parts of it are a direct approve, other parts I'm unsure.
I think we should avoid using stdout for anything, not godog related. Instead, If we really need more output or log files, we can print them on stderr. This way, we won't lose the possibility to generate cucumber reports.
Or we could create a logger that prints into a logfile. Similar to what validator is doing.
|
So my request for change would be: mv features/goscripts/* internal/
rmdir features/goscripts
sed -i 's#features/goscripts#internal#' main_test.go |
|
Could you rebase your branch against the current master? Maybe we can resolve the conflicting file |
|
any ETA when we could merge this ? |
|
Due to the amount of new commits that got merge in the remote branch, i have to start from scratch. ETA is tomorrow or friday. |
Uh oh!
There was an error while loading. Please reload this page.