allow to use SHT_REAL_NORM normalization#11
Open
nschaeff wants to merge 1 commit intofgerick:masterfrom
Open
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #11 +/- ##
==========================================
+ Coverage 45.58% 45.70% +0.12%
==========================================
Files 9 9
Lines 430 431 +1
==========================================
+ Hits 196 197 +1
Misses 234 234 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Owner
|
Can we add any tests to verify the normalizations are working as expected? |
Author
|
Do you have some test example I could adapt? |
Owner
|
Here I test the norms, it should give the same spatial field for all norms: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose in the julia interface the possibility to use "real normalization" :
cfg = SHTns.SHTnsCfg(13; norm = SHTns.Orthonormal(; real_norm=true))