feat: fix table.unpack nil handling issue specific to LuaJIT bytecode…

[Roxanne63]

feat: fix table.unpack nil handling issue specific to LuaJIT bytecode compilation

Problem: table.unpack behaves differently in LuaJIT bytecode-compiled mode (ljbc) vs standard Lua interpretation. Tables containing nil values cause argument truncation only in ljbc mode due to different internal handling of array length.

[gemini-code-assist]

Summary of Changes

Hello @Roxanne63, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a compatibility issue with table.unpack when running in LuaJIT bytecode-compiled mode. Specifically, it resolves a problem where nil values within tables led to incorrect argument truncation, ensuring consistent behavior across different Lua execution environments by explicitly passing arguments.

Highlights

• LuaJIT table.unpack Fix: Replaced table.unpack with explicit argument passing (v[1], v[2], v[3]) in lib/resty/openssl/kdf.lua to resolve an issue where nil values caused argument truncation in LuaJIT bytecode-compiled mode.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly addresses a subtle bug in LuaJIT's bytecode compilation of table.unpack when nil values are present in a table. The fix of replacing unpack(v) with explicit indexing v[1], v[2], v[3] is direct and effective, ensuring correct argument passing for option validation. I have added one suggestion to improve the readability and maintainability of the fix.

[fffonion]

Thank you @Roxanne63 !