W32: prevent "dllexport" from being added to globalvardefs when building for static linking#84
Open
umlaeute wants to merge 1 commit intofestvox:masterfrom
Open
Conversation
…g for static linking Closes: festvox#83 Signed-off-by: IOhannes m zmölnig <zmoelnig@iem.at>
umlaeute
force-pushed
the
w32-static-linking
branch
from
b40fcf2 to
5915d69
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces an
FLITE_STATICdefine.If
FLITE_STATICis defined at build-time,GLOBALVARDEFdecorator will not use__declspec(dllexport)(on Windows).This allows using a static flite on Windows (other platforms don't have this problem).
The
FLITE_STATICdefine must be set manually by whoever wants to use flite in this way.Closes: #83