Dump IPA transcription. Also fix some wrong words#115
Open
Tomotz wants to merge 12 commits intofestvox:masterfrom
Open
Dump IPA transcription. Also fix some wrong words#115Tomotz wants to merge 12 commits intofestvox:masterfrom
Tomotz wants to merge 12 commits intofestvox:masterfrom
Conversation
I think it's better they sound a bit weird than reading out the names of all the letters
Challenge - tʃælədʒ->tʃæləndʒ Isn't - ɪsnt -> ɪzənt Suggest - səɡˈdʒɛst->səˈdʒɛst
səɡˈdʒɛst->səˈdʒɛst I assume the correct way to fix would be to change the rules in cst_lts_model, but I'm afraid any change I'll try doing there will mess up many things
To allow tokens that have only puncuation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is done when you pass
-ito the cli. Input can still be from file/arg, and output is default to screen, but can be set to a file as well.note - I did not fix the byte numbers in all the lines after the words I fixed. Not sure if those are important to anything, but since I did the fixes manually, it was to much of a hustle to fix.
Suggestin it (suggestion, suggested, etc.) - apply_model gave them all a wronggsound, but since changing the model table is very complected (I assume you somehow generate that one automatically) I solved it in a hacky find and replace wayI don't think this pull request will (or even should) be merged as is, but I would love it if I can get some of this stuff into master, and if you can fix all the misspelled words I found in a less hacky way