Readers for structured and unstructured meshes #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/openmc2dolfinx/vtk_reader.py
Outdated
Comment on lines
95
to
105
| # Extract all cell connectivity data at once | ||
| cell_connectivity_raw = np.array( | ||
| [ | ||
| [ | ||
| self.grid.GetCell(i).GetPointId(j) | ||
| for j in range(self.grid.GetCell(i).GetNumberOfPoints()) | ||
| ] | ||
| for i in range(num_cells) | ||
| ], | ||
| dtype=int, | ||
| ) |
Contributor
There was a problem hiding this comment.
I guess for large meshes we want to "numpify" this
Co-authored-by: Rémi Delaporte-Mathurin <40028739+RemDelaporteMathurin@users.noreply.github.com>
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
RemDelaporteMathurin
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
With this change, we can read unstructured and structured files from openmc
Types of changes
What types of changes does your code introduce to openmc2dolfinx?
Checklist
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...