Skip to content

Conversation

@rekomodo
Copy link
Collaborator

@rekomodo rekomodo commented Aug 5, 2024

#59

@rekomodo rekomodo marked this pull request as ready for review August 9, 2024 17:52
@RemDelaporteMathurin RemDelaporteMathurin linked an issue Aug 29, 2024 that may be closed by this pull request
@RemDelaporteMathurin
Copy link
Contributor

This is a nice validation case... Don't know why we never merged this.
Maybe it's worth re-visiting this case? What do you think @KulaginVladimir @jhdark @ehodille

image

@KulaginVladimir
Copy link
Contributor

@RemDelaporteMathurin, the final plot is good. I feel like the FESTIM model should be checked.

I noticed several things to discuss:

  • reflection was not considered
  • diffusivity is for H, not for D
  • trap distribution: I'm not sure that "Implantation depth for Fe ions", presented in Table 1 from the paper, means that the created traps are distributited within this layer. Maybe, Fig. 8 can say smth?

Considering these aspects, the used trap properties might require re-consideration, no?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TDS Validation case from Oya et. al.

3 participants