Add render() method to get raw sample data.#18
Open
chr15m wants to merge 2 commits intofeross:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @feross, thanks for this wonderful library which I'm using over at https://dopeloop.ai/melody-generator. For a different application I wanted to be able to get the raw audio samples of the rendered MIDI file, and this patch adds that functionality with the
render()method. It returns a pair ofFloat32Arrays containing the left and right channel audio data, which can then be used to mix with other audio, compress to mp3, or whatever. I also updated the documentation. I know you are super busy, so thank you for considering this PR for merging. 🙏Here is some test code for trying out the
render()method: