Added faas gRPC interface definition #48
Open
+155
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rneswold
requested changes
Nov 17, 2025
rneswold
approved these changes
Nov 19, 2025
rneswold
requested changes
Jan 14, 2026
Contributor
rneswold
left a comment
rneswold
left a comment
There was a problem hiding this comment.
I'm not a fan of commenting-out code and committing it. The git history will tell you what was changed.
Are those commented-out fields going to be re-introduced at a later time? If not, just delete them. We don't have a production-ready FaaS system, so I'd renumber the fields, if you delete the commented ones.
| rpc UpdateMessageQueueTrigger(UpdateMQTriggerRequest) returns (GenericResponse); | ||
| rpc DeleteMessageQueueTrigger(DeleteMQTriggerRequest) returns (GenericResponse); | ||
|
|
||
| // Lust of functions and triggers |
Author
There was a problem hiding this comment.
I have added this features to let user know how many functions and trigger are there
Contributor
There was a problem hiding this comment.
I was giggling at your code comment "Lust of functions". 😄
Author
|
I will remove the commented part. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gRPC for fission