Add dispcount:transaction/2 for running funs in watcher context#11
Draft
Vagabond wants to merge 1 commit intoferd:masterfrom
Draft
Add dispcount:transaction/2 for running funs in watcher context#11Vagabond wants to merge 1 commit intoferd:masterfrom
Vagabond wants to merge 1 commit intoferd:masterfrom
Conversation
To avoid unnecessary calls and waiting for responses allow for a fun to be passed as a transaction that can be run by the watcher. As soon as the fun completes, the watcher is marked as free again without intervention by the calling process. This should improve throughput for use cases where the caller having direct access to the resource is not necessary.
Contributor
Author
|
Here's how I'm using it, with epgsql's async mode: prepared_query(Pool, Name, Params) ->
Ref = make_ref(),
Fun = fun(From, {Stmts, Conn}) ->
Statement = maps:get(Name, Stmts),
#statement{types = Types} = Statement,
TypedParameters = lists:zip(Types, Params),
%% construct the same kind of cast the epgsqla:prepared_statement does, but redirect
%% the output to the elli process directly
gen_server:cast(Conn, {{cast, From, Ref}, epgsql_cmd_prepared_query, {Statement, TypedParameters}})
end,
case dispcount:transaction(Pool, Fun) of
ok ->
receive
{_Conn, Ref, Res} ->
Res
after
500 ->
throw(?RESPONSE_503)
end;
{error, busy} ->
throw(?RESPONSE_503)
end. |
Owner
|
Sounds workable; might make sense to identify which request returns which results with a Ref, allowing people to parallelize calls. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To avoid unnecessary calls and waiting for responses allow for a fun to
be passed as a transaction that can be run by the watcher. As soon as
the fun completes, the watcher is marked as free again without
intervention by the calling process. This should improve throughput for
use cases where the caller having direct access to the resource is
not necessary.
This still needs tests, but I have it working in the field.