refactor(task-executor): improve task lifecycle management and timeout handling#1
Closed
refactor(task-executor): improve task lifecycle management and timeout handling#1
Conversation
…t handling - Remove deprecated EnableContainerMode flag and related logic from config and executor initialization - Add TimeoutSeconds field to Process spec for task timeout control - Enhance process executor to detect task timeout and report Timeout state with detailed substatus - Refactor task manager to maintain precise active task count via dynamic evaluation - Implement asynchronous task stop on deletion and timeout to avoid reconcile loop blocking - Update task status reconciliation with proper locking and persistent state updates - Improve internal to API task conversion to reflect timeout termination and pod status accurately - Add PodTemplateSpec support to tasks and propagate to API representations - Expand tests to cover async stop on delete, timeout detection, active task counting, and status conversion - Remove unused cached activeTasks counter and improve concurrency safety via stopping map - Simplify container executor initialization by always creating executor without conditional flag - Clean up logging and error handling in task lifecycle operations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Breaking Changes
Checklist