Squash, fix some things from NFR review #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added license * Added 'MIT License' text
* Added license * Added 'MIT License' text * Made CANSignal SignalType atomic, fixed resulting errors * Handle enums in dbc_to_h * Added MockCAN, implemented multiplexed CAN messages * Improved compatibility of multiplexed messages * Updated dbc to h with multiplexed messages * Update to dbc_to_h, updates to remove warnings (feistjo#52) Co-authored-by: Joshua Feist <joshua@navierboat.com> * Fix missing float cast (feistjo#53) * Update to dbc_to_h, updates to remove warnings * Fixed missing float cast --------- Co-authored-by: Joshua Feist <joshua@navierboat.com> * Updates to dbc_to_h and multiplexed CAN (feistjo#54) * Fixed some missing overrides * Made multiplexor index a size_t * Added data type estimation to dbc_to_h, updated can_interface.h to work with non-multiplexed signals in multiplexed messages * updated dbc_to_h to automatically fill transmit periods * Added missing static_cast to get rid of warnings --------- Co-authored-by: Joshua Feist <joshua@navierboat.com> * Made time getters const (feistjo#55) Co-authored-by: Joshua Feist <joshua@navierboat.com> * Significant updates, including TWAI ESP driver and ESP updates over CAN (feistjo#57) * Update dbc_to_h for better compatibility * Work on improving multiplexed message transmitting * Fixed some issues with multiplexed messages * Initial switch to twai driver * Fixed a couple bugs, tested and working twai * Added check to not send message when twai bus state isn't running * Made atomic work for uint64_t with freertos, updated multiplexed message handling * Preliminary support for PGNs * Added operator definitions for assigning and comparing CAN signals of the same type without having to cast to SignalType * PGN support needs testing * Marked functions as override * Static cast to fix a couple warnings * Support esp32 updates over CAN (#3) * Added support for uploading firmware to ESP32 over CAN * Updated for better compatibility with other projects * Cleanup update code, fix timeout/abort, properly close SocketCan on close * Made else if --------- Co-authored-by: Joshua Feist <joshua@navierboat.com> --------- Co-authored-by: Joshua Feist <joshua@navierboat.com> * Fixed test for new MultiplexedCANTXMessage template * Put examples in library * Added check to print if missed RX messages due to full queue for ESP, added comments to clarify differences between types of CAN Messages * Added comments * Fixed failing unit tests, added comment explaining long ternary and commented code block --------- Co-authored-by: Joshua Feist <joshua@navierboat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.