Open
Conversation
Deploying sijak with
|
| Latest commit: |
62d2924
|
| Status: | 🚫 Build failed. |
Jayden11v
reviewed
Oct 7, 2024
| profile_image: | ||
| "https://avatars.githubusercontent.com/u/33307948?s=400&u=a642bbeb47b47e203f37b47db12d2d92d8f98580&v=4", | ||
| name: "kyubumjang", | ||
| const [loginedUser, setLoginedUser] = useState<LoginUserInfo>({ |
Collaborator
There was a problem hiding this comment.
유저 정보와 관련된 코드들은 useUserInfo와 같이 커스텀 훅으로 만들어서 사용하셔도 될 것 같아요
Collaborator
There was a problem hiding this comment.
그리고 해당 컴포넌트가 가독성이 좋지않아 form 관련코드를 따로 컴포넌트로 생성하는게 좋아보여요
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#️⃣ 연관된 이슈
📝 작업 내용
스크린샷
💬 리뷰 요구사항