Open
Conversation
Deploying sijak with
|
| Latest commit: |
42055f8
|
| Status: | 🚫 Build failed. |
kyubumjang
force-pushed
the
feature/api-integration-20-3
branch
from
967fdcf to
42055f8
Compare
Jayden11v
reviewed
Oct 7, 2024
| console.log("좋아요!"); | ||
| // TODO: 좋아요 API 연동 | ||
|
|
||
| if (lectureData.heart === true) { |
Collaborator
There was a problem hiding this comment.
=== true, === false가 아닌 lectureData.heart / !lectureData.heart와 같이 하는게 더 괜찮을 것 같네요.
Jayden11v
reviewed
Oct 7, 2024
| }, | ||
| { | ||
| onSuccess: () => { | ||
| toast("좋아요 삭제 성공"); |
Collaborator
There was a problem hiding this comment.
좋아요 삭제 성공과 같은 MSG들은 constant에서 따로 상수로 정의해주세요.
SUCCESS_LIKE_MSG = ''
Jayden11v
reviewed
Oct 7, 2024
| })} | ||
| {lectureInfo.instructor_name.map((instructor) => { | ||
| return instructor.instructor_history.map((history, idx) => { | ||
| return <li key={idx}>{history.content}</li>; |
Collaborator
There was a problem hiding this comment.
key를 idx로 두게되면 react특성상 key값을 기준으로 판단을 하기에 정확하게 판단이 안 될 수도 있어요. 그래서 history의 특정 id값과 같은 것을 유니크 key값으로 설정해주세요
Jayden11v
reviewed
Oct 7, 2024
| apiRequest.post<LikeLecture["Response"]>( | ||
| `${BASE_PATH}`, | ||
| {}, | ||
| { |
Collaborator
There was a problem hiding this comment.
authorization 객체는 axios interceptor에서 공통으로 처리해주세요
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#️⃣ 연관된 이슈
📝 작업 내용
스크린샷
💬 리뷰 요구사항