Eliminate use of assert_that in favor of assert_eq #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkoncek
reviewed
Jul 22, 2025
src/jurand_test.cpp
Outdated
| using namespace java_symbols; | ||
|
|
||
| template <typename T1, typename T2> | ||
| static std::ostream &operator<<(std::ostream &os, const std::tuple<T1, T2> &t) { |
Member
There was a problem hiding this comment.
In this project we use left-side reference and pointer syntax, i.e.:
type& func(type* var);
Replace all uses of assert_that with assert_eq for consistency and clearer test failure messages. assert_eq is already used elsewhere and provides better diagnostics by showing expected vs. actual values.
Member
|
For future, when |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace all uses of assert_that with assert_eq for consistency and clearer test failure messages. assert_eq is already used elsewhere and provides better diagnostics by showing expected vs. actual values.