changed mklroot name #107
Closed
changed mklroot name #107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AugustusGreenwood
force-pushed
the
add_mkl_to_cmake_group
branch
from
203c682 to
63a1b3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very small change, but when using cmake-gui, you can group entries by their prefix. The MKLROOT entry wasn't grouped with MKL because there wasn't an underscore between MKL and ROOT.
I just changed all entries of MKLROOT to MKL_ROOT in FindDependencies.cmake, so that it will appear in the MKL group.
Testing:
After change, I confirmed that it was grouped with MKL. After, I successfully built and ran a simple model (Linux, x86_64)