Fix: update pondering message after max-analyze-time-minutes#896
Open
kaorahi wants to merge 1 commit intofeaturecat:masterfrom
Open
Fix: update pondering message after max-analyze-time-minutes#896kaorahi wants to merge 1 commit intofeaturecat:masterfrom
kaorahi wants to merge 1 commit intofeaturecat:masterfrom
Conversation
kaorahi
pushed a commit
to kaorahi/lizzie
that referenced
this pull request
Sep 1, 2021
Open
|
I think it's a good change to display the d9f755b dialog message because it's easier to visually confirm that the analysis is complete. |
Contributor
Author
|
See fdfa0af. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

"pondering on" message was not updated after max-analyze-time-minutes. thx > @hebaeba.
Though I also wrote the following dialog, it is not included in this PR because I am afraid that such warnings may be annoying. How do you think?
(d9f755b in https://github.com/kaorahi/lizzie/tree/fix_max_time2)