Skip to content

Conversation

@paulirwin
Copy link
Member

  • Bump version to 0.2.0
  • Remove JetBrains Annotations dependency
  • Upgrade dependencies including F23.Hateoas to 2.0.0 (breaking change - removes Newtonsoft.Json dependency)
  • Fix Swagger docs for response status codes and types
  • Run tests on .NET 9
  • Remove OpenAPI dependency from examples since we already have Swashbuckle; just use that

Copilot AI review requested due to automatic review settings November 7, 2025 17:27
@paulirwin paulirwin added the notes:breaking-change List under Breaking Changes for release notes label Nov 7, 2025
@github-actions
Copy link

github-actions bot commented Nov 7, 2025

Test Results

  2 files  +  1    2 suites  +1   1s ⏱️ -1s
133 tests ±  0  133 ✅ ±  0  0 💤 ±0  0 ❌ ±0 
266 runs  +133  266 ✅ +133  0 💤 ±0  0 ❌ ±0 

Results for commit 4583143. ± Comparison against base commit 4265228.

♻️ This comment has been updated with latest results.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request upgrades the project to support .NET 9 alongside .NET 8, removes the JetBrains.Annotations dependency, and updates multiple package dependencies to newer versions. The changes also enhance the Swagger/OpenAPI documentation with versioning support and add API response type annotations.

Key Changes

  • Multi-targeting support for .NET 8 and .NET 9 in test projects and CI/CD workflows
  • Removal of JetBrains.Annotations package and related attributes
  • Enhanced Swagger/OpenAPI documentation with versioned endpoints and explicit response type annotations
  • Updated test framework packages and other dependencies

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/F23.Kernel/GlobalUsings.cs Removed JetBrains.Annotations global using statement
src/F23.Kernel/F23.Kernel.csproj Bumped version to 0.2.0 and removed JetBrains.Annotations package reference
src/F23.Kernel/EventSourcing/IApplyEvent.cs Removed [UsedImplicitly] attribute following JetBrains.Annotations removal
src/F23.Kernel.Tests/F23.Kernel.Tests.csproj Added .NET 9 target framework and updated test package versions
src/F23.Kernel.Examples.AspNetCore/Program.cs Enhanced Swagger configuration with versioning and custom document info
src/F23.Kernel.Examples.AspNetCore/Infrastructure/ResultsController.cs Added ProducesResponseType attributes for better API documentation
src/F23.Kernel.Examples.AspNetCore/F23.Kernel.Examples.AspNetCore.csproj Updated Swashbuckle.AspNetCore and removed Microsoft.AspNetCore.OpenApi
src/F23.Kernel.Examples.AspNetCore/Core/ResultsEndpoints.cs Added Produces metadata for minimal API endpoints and removed unused using statements
src/F23.Kernel.AspNetCore/F23.Kernel.AspNetCore.csproj Bumped version to 0.2.0 and upgraded F23.Hateoas to 2.0.0
.github/workflows/publish.yml Added .NET 9 setup steps and removed automatic PR/push triggers
.github/workflows/ci_build.yml Added .NET 9 setup steps and modified test command

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link

github-actions bot commented Nov 7, 2025

Code Coverage

Package Line Rate Branch Rate Complexity Health
F23.Kernel 91% 85% 128
F23.Kernel.AspNetCore 100% 100% 155
Summary 95% (307 / 322) 96% (196 / 204) 283

@paulirwin paulirwin enabled auto-merge (squash) November 7, 2025 17:45
@paulirwin paulirwin merged commit 240608e into main Nov 7, 2025
4 checks passed
@paulirwin paulirwin deleted the chore/release-0.2.0 branch November 7, 2025 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

notes:breaking-change List under Breaking Changes for release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants