Open
Conversation
vanboom
force-pushed
the
master
branch
2 times, most recently
from
e30c0d8 to
e89e2fa
Compare
Adding detection for 256 color ASCII color codes.
vanboom
commented
Jul 21, 2020
| text = text.replace /\[(3[0-7])m/, (match, colorCode) => | ||
| "<p class=\"rspec-color tty-#{colorCode}\">" | ||
| text = text.replace /\[0m/g, '</p>' | ||
| text = text.replace /\x1B/g, '' |
Contributor
Author
There was a problem hiding this comment.
The [] character is caused by byte code 0x18. Strip it out and everything looks good.
Contributor
Author
There was a problem hiding this comment.
The colorize gem allows console colors, but uses the 256 color ASCII format: \u001b[38;5;${ID}m
This line will detect the color code from the 256 color mode and works with all of the primary colors: yellow, red, cyan, green, blue, etc. I have not extensively tested this with all colors in the 256 color table.
This was referenced Jun 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Save file when specs are run. See #86.