Sync from TheSuperHackers #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ectory to prevent INI CRC mismatch (#1879)
…ng in IPEnumeration::getMachineName (#1934)
…ecompression artifacts when tabbing out of the game (#1927)
… and Score videos (#1926)
…pperListNode::copyChunkData() (#1946)
…Main, Mouse, HeaderTemplate (#1939)
Crash dumps are stored in %USERPROFILE%\Documents\Command and Conquer Generals Zero Hour Data\CrashDumps
… and slow CI builds (#1973)
…ortedOpenList() (#1965)
This fixes a runtime crash in Generals due to incomplete code merging
…ons, misc formatting tweaks (#1959)
…e() and NetPacket::readFileAnnounceMessage() (#1981) Co-authored-by: JBremer <jbremer@users.noreply.github.com> Co-authored-by: SkyAero <Skyaero42@users.noreply.github.com>
…BaseHeightMap, FlatHeightMap, W3DPropDraw, W3DTreeDraw, W3DPropBuffer, W3DSnow, W3DTerrainBackground files to Core (#1991)
…ileMessage() and NetPacket::readFileAnnounceMessage() (#2005) Co-authored-by: SkyAero <Skyaero42@users.noreply.github.com>
… Shell Map (#2002) Keys P and O no longer pause the Shell Map. But Shift+P and Shift+O still do
…he disconnection menu (#2020)
…fter evacuating all passengers (#1762)
…r if passengers want to board or exit (#1787)
…r's switch case MSG_CANCEL_UNIT_CREATE (#1881)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and additions focused on code quality, build configuration, and code modernization for the GeneralsGameCode project. The most significant change is the addition of a
.clang-tidyconfiguration to enable static code analysis and enforce code quality standards. There are also multiple updates to the CMake build configuration to include previously excluded source files, and a newMiniDumpercrash dump utility is introduced. Additionally, various header files have been updated to modernize function definitions and correct minor issues.Code Quality and Static Analysis
.clang-tidyconfiguration file tailored for the project's legacy C++98/C++20 hybrid codebase, enabling a curated set of checks and naming conventions to improve code quality and maintainability.Build Configuration and Source Inclusion
Core/GameEngine/CMakeLists.txtto include several previously excluded source and header files (such asMapObject.h,MiniDumper.h,MapUtil.cpp,TerrainRoads.cpp,View.cpp, etc.), ensuring these components are now built and part of the project. [1] [2] [3] [4] [5] [6] [7]Crash Dump Support
MiniDumperutility (Include/Common/MiniDumper.h) to provide crash dump functionality, including support for minimal and full dumps, thread management, and dump directory maintenance.Modernization and Code Cleanup
inlinespecifiers from function definitions in several classes (e.g.,AsciiString,UnicodeString,RadarObject,Radar,MemoryPoolObject) to improve clarity and compatibility with static analysis tools. [1] [2] [3] [4] [5] [6]AsciiStringandUnicodeStringto beconstfor correctness and safety. [1] [2]Minor Fixes
GameAudio.h(e.g., "accomodate" → "accommodate", "Debice" → "Device"). [1] [2]GameUtility.h.