Skip to content

Conversation

@deftdawg
Copy link
Contributor

@deftdawg deftdawg commented Dec 6, 2025

  • "Run next plugin and exit" mode (--run-once)
  • A simple error message now renders on the frame when a plugin fails

- A simple error message now renders on the frame when a plugin fails
@deftdawg
Copy link
Contributor Author

deftdawg commented Dec 6, 2025

Simple error messages look like this:
(changed comic plugin font to "Tommy" to break it)

image

image = refresh_action.execute(plugin, self.device_config, current_dt)
except Exception as e:
logger.exception(f"Failed to execute refresh action for {refresh_action.get_plugin_id()}")
image = generate_error_image(f"Plugin Error:\n{refresh_action.get_plugin_id()}\n{str(e)}", self.device_config.get_resolution())
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like having the error displayed, but this causes the UI to display "Success! Display updated". I think we still want to display the error message in the UI as well when there is a failure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants