Skip to content
This repository was archived by the owner on Oct 18, 2023. It is now read-only.

Conversation

@aisayo
Copy link
Contributor

@aisayo aisayo commented Nov 16, 2022

Description

The goal of this PR is to test an upgrade to the Heroku stack from 18 to 20 since 18 will be deprecated soon

I will abide by the code of conduct

@aisayo aisayo requested a review from a team as a code owner November 16, 2022 21:20
@aisayo aisayo requested review from KostiantynPopovych and mateusdeap and removed request for a team November 16, 2022 21:20
@mateusdeap
Copy link
Member

mateusdeap commented Nov 18, 2022

@aisayo So, I noticed that some gems were upgrades, the Gemfile.next.lock was removed and the schema seems to have been updated, maybe because of a different database version or pg version, I'm unsure. Was all that intentional or needed?

@kindoflew
Copy link
Contributor

hello @hmdros! can you review this when you have a chance? thanks!

@aisayo aisayo temporarily deployed to pecas-upgrade-heroku-st-aczl1c December 2, 2022 18:58 Inactive
@ABizzinotto ABizzinotto temporarily deployed to pecas-upgrade-heroku-st-htzdjk December 2, 2022 19:47 Inactive
@kindoflew
Copy link
Contributor

@hmdros ping

@kindoflew kindoflew requested a review from hmdros December 5, 2022 21:38
@mateusdeap mateusdeap marked this pull request as draft December 6, 2022 14:40
@mateusdeap
Copy link
Member

@kindoflew So, now that I see the PR description and talking to @aisayo, she clarified that this isn't ready for review just yet. Converting the PR to a draft so we can ignore this for now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants