Conversation
JanFSchulte
approved these changes
Feb 12, 2026
nghielme
pushed a commit
that referenced
this pull request
Feb 12, 2026
JanFSchulte
pushed a commit
that referenced
this pull request
Feb 13, 2026
* Add utility functions for generating unique test case identifiers in pytest - Introduced `get_pytest_case_id` and `get_pytest_baseline_name` functions in `conftest.py` to create unique identifiers for parametrized test cases and baseline files. - Updated multiple test files to utilize these functions for generating output directory names, ensuring consistency and avoiding collisions in test outputs. - Refactored test function signatures to include the `request` parameter where necessary for accessing the pytest request context. * pre-commit fixes * Refactor pytest utility functions for unique test case identifiers - Introduced `_sanitize_test_id` function to handle sanitization of test identifiers for file paths. - Updated test files to utilize the new `get_pytest_case_id` function for generating baseline file names, ensuring uniformity in output directory naming. - Removed obsolete baseline files and added new ones to reflect updated test cases. * Uniform test root path (#1435) it is actually overridden by my contribution * pre-commit fixes * Refactor test case identifier handling in pytest - Replaced the `get_pytest_case_id` function with a new fixture `test_case_id` to streamline the generation of unique identifiers for test cases. - Updated multiple test files to utilize the new `test_case_id` fixture, ensuring consistent output directory naming across tests. - Removed obsolete references to the old identifier function. * Refactor test function signatures to use `test_case_id` - Updated the `garnet_models` and `garnet_stack_models` fixtures to replace the `request` parameter with `test_case_id` f * Refactor pytest fixtures and update baseline files - Changed the `scope` of some pytest fixtures from 'module' to default. - Updated the `_sanitize_test_id` function to remove the prefix 'hls4ml/test/pytest/'. - New mapping of old baselines json file to new naming style. * Update CI template to include all tar.gz files in the pytest directory - Modified the paths in the CI template to match all tar.gz files under the test/pytest directory instead of a specific pattern, required with the new naming convention. --------- Co-authored-by: Jovan Mitrevski <jmitrevs@fnal.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The keras v3 api tests currently put all the results in the
/tmpdirectory, unlike every other test. This PR just makes it uniform, putting the results inPath(__file__).parent.I also added v3 to the folder name to not conflict with the v2 versions of the tests.
Type of change
Tests
Test Configuration:
Checklist
pre-commiton the files I edited or added.