Skip to content

Conversation

@pre-commit-ci
Copy link
Contributor

@pre-commit-ci pre-commit-ci bot commented Feb 2, 2026

updates:
- [github.com/tox-dev/pyproject-fmt: v2.11.1 → v2.12.1](tox-dev/pyproject-fmt@v2.11.1...v2.12.1)
@JanFSchulte JanFSchulte merged commit d051785 into main Feb 4, 2026
5 checks passed
@JanFSchulte JanFSchulte deleted the pre-commit-ci-update-config branch February 4, 2026 15:46
Abubakar-rashid pushed a commit to Abubakar-rashid/hls4ml that referenced this pull request Feb 4, 2026
updates:
- [github.com/tox-dev/pyproject-fmt: v2.11.1 → v2.12.1](tox-dev/pyproject-fmt@v2.11.1...v2.12.1)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
JanFSchulte pushed a commit that referenced this pull request Feb 9, 2026
* Fix Keras v3 model conversion in numerical profiling

* Address review feedback: remove unnecessary else clause and add test to LONGLIST

- Removed else clause in convert_from_config() as it's no longer needed
- Added test_keras_v3_profiling to LONGLIST in generate_ci_yaml.py for proper CI environment

* Fix line length issue in generate_ci_yaml.py

Break KERAS3_LIST into multiple lines to comply with max line length of 125 characters

* Einsum and EinsumDense for oneAPI

* Add tests

* Add tests

* Remove hgq2 from testing-keras3 dependencies and test_hgq2_mha from KERAS3_LIST

As requested by reviewers:
- Removed hgq2>=0.0.1 from testing-keras3 optional dependencies
- Removed test_hgq2_mha from KERAS3_LIST

* [pre-commit.ci] pre-commit autoupdate (#1425)

updates:
- [github.com/astral-sh/ruff-pre-commit: v0.14.13 → v0.14.14](astral-sh/ruff-pre-commit@v0.14.13...v0.14.14)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* Add LHC trigger use case context to README (#1418)

* Add LHC trigger use case context to README

* Clarify hls4ml application domains in README

---------

Co-authored-by: Siddardha Desu <siddardhadesu@Siddardhas-MacBook-Air.local>

* [pre-commit.ci] pre-commit autoupdate (#1430)

updates:
- [github.com/tox-dev/pyproject-fmt: v2.11.1 → v2.12.1](tox-dev/pyproject-fmt@v2.11.1...v2.12.1)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* Fix Keras v3 profiling tests: build models and correct bar count expectations

- Call model.build() or pass sample data to initialize Keras v3 models
- Fix bar count assertions to match actual behavior (1 bar per layer, not per weight)
- Ensures models have defined inputs before profiling

* Fix qkeras import to avoid namespace conflict with hgq2

- Change 'import qkeras' to 'from qkeras import QActivation' in profiling.py
- This protects against hgq2's qkeras compatibility layer causing conflicts
- Add back hgq2>=0.0.1 to testing-keras3 dependencies
- Add back test_hgq2_mha to KERAS3_LIST

As requested by reviewers to resolve qkeras/hgq2 namespace issues.

* Fix activation and batch norm tests

- Call model with data instead of just build() for activation test
- Fix batch norm expected bar count to 3

* Add new arguments to convert_from_keras_model call

Added allow_da_fallback and allow_v2_fallback args from PR #1429

* Fix Keras v3 profiling tests - 4/5 passing

One test (hls_model comparison) is skipped because get_unoptimized_hlsmodel()
tries to recreate the model from saved config, which fails for Keras v3 due to
config format changes. This is a library issue in keras_v2_to_hls parser that
needs a separate fix.

---------

Co-authored-by: Jovan Mitrevski <jmitrevs@fnal.gov>
Co-authored-by: laurilaatu <l.laatu@imperial.ac.uk>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: siddardhadesu <153359094+siddardhadesu@users.noreply.github.com>
Co-authored-by: Siddardha Desu <siddardhadesu@Siddardhas-MacBook-Air.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant